Repository navigation
chore: openspec setup - #5006
Conversation
2ba2bdf to
c03b0f7
Compare
|
Things to add/check:
|
c03b0f7 to
8b027fc
Compare
|
|
||
| tasks: | ||
| - Order implementation tasks following the module dependency chain — owncloudComLibrary first, then owncloudData, owncloudDomain, owncloudApp last. | ||
| - Add unit tests only for layers where they are established — UseCases in owncloudDomain, Repository/DataSource implementations in owncloudData, ViewModels in owncloudApp. Do not add unit tests to owncloudComLibrary unless the change directly modifies library utilities there. |
There was a problem hiding this comment.
Unit tests for viewModels are not being maintained at this moment
There was a problem hiding this comment.
Would it make sense to let the agent develop tests there? if not, we should remove that part
There was a problem hiding this comment.
These tests have not been refactored to follow the new convention we are using for repositories and datasources. I'd refactor them but not now. We can try to use openspec for this refactor
| - Cross-check the implementation against design.md — confirm the documented data-flow path (Fragment → ViewModel → UseCase → Repository → DataSource) is reflected in the actual code. | ||
| - Confirm all tasks in tasks.md are marked complete; flag any that were skipped or partially done. | ||
| - Run ./gradlew detekt on all affected modules and confirm zero issues. | ||
| - Run ./gradlew testDebugUnitTest --continue and confirm all unit tests pass. |
There was a problem hiding this comment.
I'd use the same command that we have in the CI system for unit tests. Is it OK for you? 🤔
| - Run ./gradlew testDebugUnitTest --continue and confirm all unit tests pass. | |
| - Run ./gradlew testDebugUnitTest testMdmDebugUnitTest --continue and confirm all unit tests pass. |
| archive: | ||
| guidance: | ||
| - Verify changelog/unreleased/<PR-number> exists and is correctly filled in before archiving. | ||
| - Confirm ./gradlew detekt and ./gradlew testDebugUnitTest --continue all pass. |
There was a problem hiding this comment.
The same than the previous comment 🔝
| tasks: | ||
| - Order implementation tasks following the module dependency chain — owncloudComLibrary first, then owncloudData, owncloudDomain, owncloudApp last. | ||
| - Add unit tests only for layers where they are established — UseCases in owncloudDomain, Repository/DataSource implementations in owncloudData, ViewModels in owncloudApp. Do not add unit tests to owncloudComLibrary unless the change directly modifies library utilities there. | ||
| - Add instrumented tests (androidTest) only when the change involves Room entities, DAOs, or DataSource implementations in owncloudData. |
There was a problem hiding this comment.
No instrumented tests have been added in a long time. Could this line be removed?
There was a problem hiding this comment.
Instrumented test are not only UI tests, also DB tests. In case new DB stuff is added, shouldn't the test be added as well?
There was a problem hiding this comment.
The same than unit tests for view models. I'd remove this line from config.yml and try to refactor these tests using openspec, but not now. Do you agree?
| apply: | ||
| guidance: | ||
| - After implementing each module layer, run ./gradlew detekt on that module before moving to the next. | ||
| - Write unit tests in a dedicated task group, not scattered across implementation tasks. |
There was a problem hiding this comment.
The unit tests tasks should be the last ones to run
This requirement could be added here, in this line
8b027fc to
8c4fec8
Compare
Signed-off-by: Jesus Recio <jrecio@izertis.com>
8c4fec8 to
53acef3
Compare
Signed-off-by: Jesus Recio <jrecio@izertis.com>
Signed-off-by: Jesus Recio <jrecio@izertis.com>
53acef3 to
1e03949
Compare
joragua
left a comment
joragua
left a comment
There was a problem hiding this comment.
LGTM! Let's see how openspec works with this configuration 🚀
2 participants
Related Issues
App:
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA